UriInfo class is improperly parsing URIs #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UriInfo class was not respecting the URI port and would throw an ArgumentOutOfRangeException if no querystring was defined.
|
LGTM 👍 thanks for retargeting! |
Mpdreamz
added a commit
that referenced
this pull request
Dec 30, 2015
UriInfo class is improperly parsing URIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-submit of PR #1651 against the master branch. I've also submitted this change as another pull request to the PUrify-net repository.
It looks like commit 5b0bd6c refactored this class and lost pieces of the code that respect port numbers as well as the absence of query strings in the given URI.
This was causing
System.ArgumentOutOfRangeException : StartIndex cannot be less than zero.exceptions to be thrown from my project which is targeting .NET 4.6.I just took the same code in the UriInfo class prior to commit 5b0bd6c and re-added it to the refactored class.